Let remove_redundant_constraints return an empty list if infeasible
#3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Sep 25, 2024
| @@ -253,8 +253,7 @@ function remove_redundant_constraints(constraints::AbstractVector{S}; | |||
| if remove_redundant_constraints!(constraints_copy; backend=backend) | |||
| return constraints_copy | |||
| else # the constraints are infeasible | |||
| N = eltype(first(constraints)) | |||
| return EmptySet{N}(dim(constraints[1])) | |||
| return nothing | |||
There was a problem hiding this comment.
maybe lets instead return an array of the same type as constraints if it failed to find a reduction.
schillic
changed the title
remove_redundant_constraints return nothingremove_redundant_constraints return an empty list if infeasible
schillic
force-pushed
the
schillic/rrc
branch
from
ce72ee7
to
5709add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
remove_redundant_constraintsreturns anEmptySetif the constraints are contradicting. I think this is unexpected. Instead, I suggest to returnnothing.